'Run Client' Crash with latest snapshot

Published by AOCAWOL on
Status
Works as designed
Issue description

Hi, I've been trying to convert my mod to 1.14 and it says that it's all good but when I try to run the client to test it out, it gives me this:

https://pastebin.com/zYCfyAK7

Issue comments

I attached my workspace to the issue :) from what I could find, it says what is causing it is that there is some unknown character in front of my mod register id which is screwing it all up?

this line specifically

m1;31m18:05.32 [modloading-worker-9/ERROR] [ne.mi.fm.ja.FMLModContainer/]: Exception caught during firing event: Non [a-z0-9/._-] character in path of location: byg:@registryname

 

 

Indeed, I will load the workspace and try to find which element is causing this and why. Thank you for the info.

I did? But it apears to not work when I do so, I'm using the .zip workspace. What email can I send it to instead?

I know I'm probably just being really dumb but I can't find an email anywhere on pylo.co? There is this contact thing but it doesn't let me attach files to that. 

Send email to support at pylo co, just add at and dots in the mail, I wrote it like this to avoid SPAM mail scan bots.

Just a heads up and unrelated to the ticket, you should dedicate a folder for each workspace, making a workspace in install dir of MCreator is generally not a good idea.

It seems that 1.12.2 permitted whitespace in texture file names although this was not allowed, now 1.14.4 does not accept this at all.

Texture called "food_roasted ruto1.png" in your mod contains whitespace and causes a crash. Rename this texture or reimport it without whitespace.

Hey, so I'm still getting the same crash but now it's just with plants:
        0: NORMAL
        1: net.minecraftforge.eventbus.EventBus$$Lambda$2084/1823741948@50cc84fe
net.minecraft.util.ResourceLocationException: Non [a-z0-9/._-] character in path of location: byg:@registryname
    at net.minecraft.util.ResourceLocation.<init>(ResourceLocation.java:30)
    at net.minecraft.util.ResourceLocation.<init>(ResourceLocation.java:35)
    at net.mcreator.byg.MCreatorRose.init(MCreatorRose.java:81)
    at net.mcreator.byg.byg.lambda$init$1(byg.java:56)
    at java.util.ArrayList.forEach(ArrayList.java:1257)
    at net.mcreator.byg.byg.init(byg.java:56)
    at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:212)
    at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:204)
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:258)
    at net.minecraftforge.fml.javafmlmod.FMLModContainer.fireEvent(FMLModContainer.java:106)
    at java.util.function.Consumer.lambda$andThen$0(Consumer.java:65)
    at java.util.function.Consumer.lambda$andThen$0(Consumer.java:65)
    at net.minecraftforge.fml.ModContainer.transitionState(ModContainer.java:112)
    at net.minecraftforge.fml.ModList.lambda$null$10(ModList.java:134)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382)
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
    at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
    at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
    at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
    at java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:401)
    at java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:734)
    at java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
    at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
    at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
    at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:650)
    at net.minecraftforge.fml.ModList.lambda$dispatchParallelEvent$11(ModList.java:134)
    at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1386)
    at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
    at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
    at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
    at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

yeah so it's just doing it to everything. I removed all my plants and now its doing it to my structures and so forth..? (FYI I made a new workspace to try and give it a fresh start and changed my textures before actually loading it up)

The error you pasted still refers to the rose element:

net.minecraft.util.ResourceLocationException: Non [a-z0-9/._-] character in path of location: byg:@registryname
    at net.minecraft.util.ResourceLocation.<init>(ResourceLocation.java:30)
    at net.minecraft.util.ResourceLocation.<init>(ResourceLocation.java:35)
    at net.mcreator.byg.MCreatorRose.init(MCreatorRose.java:81)

I am not sure why it would be still happening if you deleted the texture as the first error definitely referred to the texture file. 

Could you please attach or otherwise send your new workspace that causes this problem too? Thanks :)

You sent me 1.12.2 version again on this link. Is this correct?

But I have converted it to 1.14.4 and checked it.

Mod element Rudobeansroasted still refers to the texture file "food_roasted ruto1" and it is normal to crash if you still require the path with whitespace to load. Changing the texture of this mod element to a texture with a valid name changed the error to crash because of the texture: "kasai ore".

I recommend you make sure to rename all textures and clear all references to such textures.

Scrolling through workspace and checking which mod elements do not have a texture would be a good start. Some I found:

  • Rudobeans
  • Kasaiore

But you can find them themselves and fix this yourself, I believe ;)

well i send the 1.12 one cuz thats just the one i get from mcreator 1.9.1 which i then convert to 1.14. And Like, you don't understand, I deleted the rudo beans and the kasai ore and all the ties to them and their textures and it still gave me those errors even after I did all that?  and I triple checked my textures to see if anymore of them had whitespace and they didnt? I'll try again and see if I was just being unlucky..?

Look, you are sending me workspace and asking to do changes myself after converting to 1.14.4. I can not see how we can come to the same results this way? I well understand what you mean, there is no need for tone like you have right now. I have no obligation to help you and do this in my goodwill, I do not deserve to be spoken to this way and will refuse to help with such an attitude.

You can send me your workspace after you do all the changes (converted to 1.14.4 and removed all the elements as you said) and I will check why it is happening.

Sorry if it came across in a negative tone, I was really just saying if I was just doing something wrong and that I'll check :(

If you can not resolve it, I suggest you upload the workspace in 1.14.4 with all your changes done so I can get hands-on directly on your situation without having to attempt to recreate it.

Your mod element called Firecracker is referring to the biome "BCanyons" which seems you have deleted as it is not in the workspace, but Firecracker is still set to spawn in this biome. On the restriction biomes, this biome appears as byg:@registryname. Remove that entry from the list.

After I did this, the error still happened, but now for the mod element Rose (you can check this from the log):

net.minecraft.util.ResourceLocationException: Non [a-z0-9/._-] character in path of location: byg:@registryname
   at net.minecraft.util.ResourceLocation.<init>(ResourceLocation.java:30 ) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading}
   at net.minecraft.util.ResourceLocation.<init>(ResourceLocation.java:35 ) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading}
   at net.mcreator.byg.MCreatorRose.init(MCreatorRose.java:81 ) ~[main/:?] {re:classloading,pl:object_holder_definalize:A}
   at net.mcreator.byg.byg.lambda$init$1(byg.java:56 ) ~[main/:?] {re:classloading}
   at java.util.ArrayList.forEach(ArrayList.java:1257 ) ~[?:1.8.0_222] {}
   at net.mcreator.byg.byg.init(byg.java:56 ) ~[main/:?] {re:classloading}

The same problem was there, byg:@registryname on the biomes list as one biome was removed.

I suggest you to check for all like these. May I know why you removed some of these biomes in the first place?

Well the canyons was roved in my workspace almost 2 weeks ago simply because I didn't want it. But that's weird cuz in my 1.9.1 Mcreator I never got any errors about that. Well thank you so much. I'll try fixing that and seeing if it works.

Minecraft 1.14.4 is much more restrictive which is not inherently a bad thing as it will force devs to cleanup their mods from broken references.

You are welcome!