Biome/Dim Layer Bug (1.14) and On world joining Crash.

Issue description

So, theres a bug with the Biome/Dim Layer, when im in my custom dim its spawning 4 layers of my Grass. even if i set my dirt to 2.Layer of the BIOME.

And theres sometimes a crash when joining an world :/

Crash Report:

---- Minecraft Crash Report ----
// Hi. I'm Minecraft, and I'm a crashaholic.

Time: 26.11.19 11:01
Description: mouseClicked event handler

java.lang.NullPointerException: mouseClicked event handler
   at cpw.mods.modlauncher.TransformerClassWriter$SuperCollectingVisitor.lambda$visit$0(TransformerClassWriter.java:137) ~[modlauncher-4.1.0.jar:?] {}
   at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948) ~[?:1.8.0_222] {}
   at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:647) ~[?:1.8.0_222] {}
   at cpw.mods.modlauncher.TransformerClassWriter$SuperCollectingVisitor.visit(TransformerClassWriter.java:135) ~[modlauncher-4.1.0.jar:?] {}
   at org.objectweb.asm.tree.ClassNode.accept(ClassNode.java:368) ~[asm-tree-6.2.jar:?] {}
   at cpw.mods.modlauncher.TransformerClassWriter.computeHierarchy(TransformerClassWriter.java:74) ~[modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.TransformerClassWriter.<init>(TransformerClassWriter.java:48) ~[modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.TransformingClassLoader$DelegatedClassLoader.findClass(TransformingClassLoader.java:241) ~[modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:128) ~[modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:98) ~[modlauncher-4.1.0.jar:?] {}
   at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_222] {}
   at net.minecraft.client.Minecraft.launchIntegratedServer(Minecraft.java:1632) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
   at net.minecraft.client.gui.screen.WorldSelectionList$Entry.func_214443_e(WorldSelectionList.java:332) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.gui.screen.WorldSelectionList$Entry.func_214438_a(WorldSelectionList.java:255) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.gui.screen.WorldSelectionList$Entry.mouseClicked(WorldSelectionList.java:228) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.gui.widget.list.AbstractList.mouseClicked(AbstractList.java:290) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.gui.INestedGuiEventHandler.mouseClicked(INestedGuiEventHandler.java:28) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.MouseHelper.lambda$mouseButtonCallback$0(MouseHelper.java:87) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.gui.screen.Screen.wrapScreenError(Screen.java:441) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.MouseHelper.mouseButtonCallback(MouseHelper.java:85) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36) ~[lwjgl-glfw-3.2.2.jar:build 10] {}
   at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.2.2.jar:build 10] {}
   at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3101) ~[lwjgl-glfw-3.2.2.jar:build 10] {}
   at net.minecraft.client.MainWindow.poll(MainWindow.java:403) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.MainWindow.update(MainWindow.java:273) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at net.minecraft.client.Minecraft.updateDisplay(Minecraft.java:982) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
   at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:946) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
   at net.minecraft.client.Minecraft.run(Minecraft.java:384) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
   at net.minecraft.client.main.Main.main(Main.java:128) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_222] {}
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_222] {}
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_222] {}
   at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_222] {}
   at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:55) ~[forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {}
   at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-4.1.0.jar:?] {}
   at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-4.1.0.jar:?] {}
   at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:101) [forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar:?] {}

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Client thread
Stacktrace:
   at cpw.mods.modlauncher.TransformerClassWriter$SuperCollectingVisitor.lambda$visit$0(TransformerClassWriter.java:137)
   at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
   at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:647)
   at cpw.mods.modlauncher.TransformerClassWriter$SuperCollectingVisitor.visit(TransformerClassWriter.java:135)
   at org.objectweb.asm.tree.ClassNode.accept(ClassNode.java:368)
   at cpw.mods.modlauncher.TransformerClassWriter.computeHierarchy(TransformerClassWriter.java:74)
   at cpw.mods.modlauncher.TransformerClassWriter.<init>(TransformerClassWriter.java:48)
   at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120)
   at cpw.mods.modlauncher.TransformingClassLoader$DelegatedClassLoader.findClass(TransformingClassLoader.java:241)
   at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:128)
   at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:98)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
   at net.minecraft.client.Minecraft.launchIntegratedServer(Minecraft.java:1632)
   at net.minecraft.client.gui.screen.WorldSelectionList$Entry.func_214443_e(WorldSelectionList.java:332)
   at net.minecraft.client.gui.screen.WorldSelectionList$Entry.func_214438_a(WorldSelectionList.java:255)
   at net.minecraft.client.gui.screen.WorldSelectionList$Entry.mouseClicked(WorldSelectionList.java:228)
   at net.minecraft.client.gui.widget.list.AbstractList.mouseClicked(AbstractList.java:290)
   at net.minecraft.client.gui.INestedGuiEventHandler.mouseClicked(INestedGuiEventHandler.java:28)
   at net.minecraft.client.MouseHelper.lambda$mouseButtonCallback$0(MouseHelper.java:87)

-- Affected screen --
Details:
   Screen name: net.minecraft.client.gui.screen.WorldSelectionScreen
Stacktrace:
   at net.minecraft.client.gui.screen.Screen.wrapScreenError(Screen.java:441)
   at net.minecraft.client.MouseHelper.mouseButtonCallback(MouseHelper.java:85)
   at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36)
   at org.lwjgl.system.JNI.invokeV(Native Method)
   at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3101)
   at net.minecraft.client.MainWindow.poll(MainWindow.java:403)
   at net.minecraft.client.MainWindow.update(MainWindow.java:273)
   at net.minecraft.client.Minecraft.updateDisplay(Minecraft.java:982)
   at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:946)
   at net.minecraft.client.Minecraft.run(Minecraft.java:384)
   at net.minecraft.client.main.Main.main(Main.java:128)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:498)
   at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:55)
   at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37)
   at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54)
   at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72)
   at cpw.mods.modlauncher.Launcher.run(Launcher.java:81)
   at cpw.mods.modlauncher.Launcher.main(Launcher.java:65)
   at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:101)

-- System Details --
Details:
   Minecraft Version: 1.14.4
   Minecraft Version ID: 1.14.4
   Operating System: Windows 10 (amd64) version 10.0
   Java Version: 1.8.0_222, BellSoft
   Java VM Version: OpenJDK 64-Bit Server VM (mixed mode),
   Memory: 396178376 bytes (377 MB) / 1028128768 bytes (980 MB) up to 1875378176 bytes (1788 MB)
   CPUs: 8
   JVM Flags: 1 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump
   ModLauncher: 4.1.0+62+5bfa59b
   ModLauncher launch target: fmluserdevclient
   ModLauncher naming: mcp
   ModLauncher services:
       /eventbus-1.0.0-service.jar eventbus PLUGINSERVICE
       /forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-launcher.jar object_holder_definalize PLUGINSERVICE
       /forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-launcher.jar runtime_enum_extender PLUGINSERVICE
       /accesstransformers-1.0.1-milestone.0.1+94458e7-shadowed.jar accesstransformer PLUGINSERVICE
       /forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-launcher.jar capability_inject_definalize PLUGINSERVICE
       /forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-launcher.jar runtimedistcleaner PLUGINSERVICE
       /forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-launcher.jar fml TRANSFORMATIONSERVICE
   FML: 28.1
   Forge: net.minecraftforge:28.1.90
   FML Language Providers:
       javafml@28.1
       minecraft@1
   Mod List:
       client-extra.jar Minecraft {minecraft@1.14.4 DONE}
       main TerrariaRefined {terrariarefined@1.0.0 DONE}
       forge-1.14.4-28.1.90_mapped_snapshot_20190719-1.14.3-recomp.jar Forge {forge@28.1.90 DONE}
   Launched Version: MOD_DEV
   LWJGL: 3.2.2 build 10
   OpenGL: Intel(R) UHD Graphics 630 GL version 4.5.0 - Build 23.20.16.5018, Intel
   GL Caps: Using GL 1.3 multitexturing.
Using GL 1.3 texture combiners.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Shaders are available because OpenGL 2.1 is supported.
VBOs are available because OpenGL 1.5 is supported.

   Using VBOs: Yes
   Is Modded: Definitely; Client brand changed to 'forge'
   Type: Client (map_client.txt)
   Resource Packs: mod_resources, vanilla, file/[v1.1] [1.9] TerrariaCraft.zip (incompatible)
   Current Language: English (US)
   CPU: 8x Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz

Issue comments

oh and there are flying trees :(

The crash might have to do with Minecraft Forge based on the log (bug, forge is not stable yet), the same might be with grass.

Flying trees like where, how, what type of tree, possibly workspace? I need more context :D

added the workspace, go to the dim, (from dirt the frame, and the igniter in the tools tab)

and then you see the flying trees :(

and we cant save structures in structure blocks (mcreator latest snapshot ) :(

What happens when you try to save it?

it says:

minecraft:meteorite saved or something, and when i try to import it, it doesnt show the strurcture

For the workspace, which biome has floating trees? I have imported your workspace and all custom biomes have set AIR for the tree block.

I see, you set trees to be structures, there is no good guarantee for this to work as structures check the gound in their corner and corner can have ground block, but actual tree not.

I recommend you to use tree generator in biome or tree structure in biome, although the latter can cause some problems too. We do plan to improve this in later updates.

For structure import from Minecraft, the bug will be fixed in next release, they changed the structures folder location in 1.13

Ok, thanks for the replies!

The problem is, i have multiple tree structures. Could you maybe make you can choose more "custom trees" in the biome section?

Yes, this is planned, I think there is a ticket covering this.

ok, thats cool, one more thing , the cooldown item does not work in ranged items .(i only tested ranged)

you can see this in my workspace (use the copper bow)

This is normal, as the cooldown item only works with certain actions.

weird, bc in 1.9.1 it worked....

Do you use it on 1.12.2 or 1.14.4 in 2019.5?

when you mean when it worked it was 1.9.1 (so 1.12.2)

when you mean it when it doesnt work, it was 1.14.4

It could be that 1.14.4 changed the way cooldown works as we use the same event triggers in 1.14.4 as in 1.12.2 for ranged item fire action.

Ok! Thanks for replies! Is there a little chance we can get a procedure like this?:

Has this entity active potion: (PotionEffect) and Potion Level (PotionLevel)

so we can check what Level the potion has? like i want if the player has CustomEffect level 3 or something

I believe this is what you are looking for: https://mcreator.net/tracker/issue/54959

Do some research on the website ;)

oh sry and thanks

PS: Do one of my 2 MOTWS (Cosmocraft/TerraCore) get in the 2019 Recap?

If they were MOTW in 2019, they most likely will. Keep in mind I do not manage MOTWs, but Matej

Ok, good to know, bc i won 2 times this year.