Custom log blocks do not properly rotate with structures

Upvotes: 3
Issue description

I have noticed some issues regarding structure generation and through testing with the structure for tree generation.

This first issue is trees structures will generate in the water using structures. This would be a good feature to enable if the creator wishes to use this mechanic. However, it can look messy if you're not going for that look.
 

Trees underwater in large lakes in a custom dimension.

The other issue I have noticed is that trees still float from time to time, I know that I reported this but before but I did not know if you still are working on it or if its been thought to be fixed but I wanted to remind you that floating trees are a issue still :)

And lastly there is one last bug I noticed only on the 1.14.4 version that I can tell, if the block is on log rotation it sometimes rotates sideways in the structure. I am not sure if it does it with other rotation formats but it could be an issue across the board with the rotation feature.

Log block rotation issue

Issue comments

This first issue is trees structures will generate in the water using structures. This would be a good feature to enable if the creator wishes to use this mechanic. However, it can look messy if you're not going for that look.

Make sure to select proper ground detection (you have two options there).

The other issue I have noticed is that trees still float from time to time, I know that I reported this but before but I did not know if you still are working on it or if its been thought to be fixed but I wanted to remind you that floating trees are a issue still :)

This one is quite hard to make a universal fix for it, we will consider adding offset point to define at which X and Z coordinate in the structure, the ground checking should be done (so one can define the point where the tree grows from).

And lastly there is one last bug I noticed only on the 1.14.4 version that I can tell, if the block is on log rotation it sometimes rotates sideways in the structure. I am not sure if it does it with other rotation formats but it could be an issue across the board with the rotation feature.

I will check this and try to fix this. Did this happen in 1.12.2 too?

I don't know if 1.12.2 for MCreator 2019.5 has the same issue, however, it did not happen in 1.12.2 for MCreaor 1.9.1 blocks in 1.9.1 used the same config as I used in 1.9.1 so I know for sure its a new bug, I don't think I started the test environment on 1.12.2 for MCreator 2019.5 so I can't recall if it happened on this version.

Submitted by AOCAWOL on Tue, 12/24/2019 - 00:39

The log rotation issue happens in 1.12.2 as well 

Sorry and what is the difference between "First Block" and "First motion blocking block" and would that have any effect on spawning in the water?

Ground is detected by going from top-down from build limit and finding the first block, now it depends if it checks for the first motion blocking block or non-blocking block. Example of motion blocking blocks is the stone block, non-blocking blocks are flowers, water, ...

I don't know if 1.12.2 for MCreator 2019.5 has the same issue, however, it did not happen in 1.12.2 for MCreaor 1.9.1 blocks in 1.9.1 used the same config as I used in 1.9.1 so I know for sure its a new bug, I don't think I started the test environment on 1.12.2 for MCreator 2019.5 so I can't recall if it happened on this version.

This bug was introduced by this issue I believe: 

  • [Bugfix #51063] Custom blocks did not properly rotate in structures

This bug was introduced by this issue: 

  • [Bugfix #51063] Custom blocks did not properly rotate in structures


Donate to MCreator

By donating to developers you can speed up development, as with more resources, we can dedicate more time to MCreator. It is a free project made by developers working on it in their free time.