[FIXED] Vanilla glass pane and vanilla wall don't connect to custom wall

Started by Azarilh on Thu, 02/04/2021 - 21:40

Topic category: Help with modding (Java Edition)

Last seen on 22:55, 24. Feb 2021
Joined Jun 2018
Points:

User statistics:

  • Modifications:
  • Forum topics:
  • Wiki pages:
  • Tracker tickets:
  • MCreator plugins:
  • Comments:
[FIXED] Vanilla glass pane and vanilla wall don't connect to custom wall
Thu, 02/04/2021 - 23:24 (edited)

Example

As you can see from the picture, there are a few problems with custom walls. First thing they don't connect to glass panes like vanilla walls do; second problem is that it tries to connect to vanilla walls but the vanilla walls do not connect to custom ones.

This is currently a limitation to the wall property that MCreator gives, i'd like it to be fixed but in the meantime there must be a way to fix this by editing the code, i wonder if someone already did this.

EDIT: Ok maybe i am missing something after all and it's my fault.

Edited by Azarilh on Thu, 02/04/2021 - 23:24
Last seen on 22:55, 24. Feb 2021
Joined Jun 2018
Points:

User statistics:

  • Modifications:
  • Forum topics:
  • Wiki pages:
  • Tracker tickets:
  • MCreator plugins:
  • Comments:
Ok so i solved it partially…
Thu, 02/04/2021 - 22:18

Ok so i solved it partially by adding the file "[mod's jar]/data/minecraft/tags/blocks/walls.json" and writing inside

{  "replace": false,  "values": [    "mod_name:custom_wall", "mod_name:suctom_wall2"  ]  }

Now custom walls connect to vanilla walls, while vanilla glass panes try to connect to custom walls but the custom walls don't. So what now?

Example

Last seen on 22:55, 24. Feb 2021
Joined Jun 2018
Points:

User statistics:

  • Modifications:
  • Forum topics:
  • Wiki pages:
  • Tracker tickets:
  • MCreator plugins:
  • Comments:
FIXED! Ok so i had to edit…
Thu, 02/04/2021 - 23:21

FIXED!

Ok so i had to edit the code of the wall blocks in MCreator. Find this line:

boolean flag = state.getBlock() instanceof WallBlock || state.getBlock() instanceof FenceGateBlock && FenceGateBlock.isParallel(state, face);

And add this before the semicolon:

|| state.getBlock() instanceof PaneBlock

 

Result:

Example

The proper way to do this is…
Fri, 02/05/2021 - 17:25

The proper way to do this is to tag your block in walls tag group

Last seen on 22:55, 24. Feb 2021
Joined Jun 2018
Points:

User statistics:

  • Modifications:
  • Forum topics:
  • Wiki pages:
  • Tracker tickets:
  • MCreator plugins:
  • Comments:
How do you do this? I haven…
Wed, 02/10/2021 - 13:02

How do you do this? I haven't seen such an option in the block settings and anywhere else. I can only make new tags.