Minecraft crashes and breaks structures generated with procedures

Upvotes: 0
Issue description

Sooo for some reason structures break and crash minecraft when generated.

I made multiple structures and added a procedure to "On structure instance generated" which places multiple parts of the structures.

This technique worked perfectly before but now minecraft crashes and break the structures.

broken templebroken dungeon

Not just with big ones but with small ones as well 

Missing a roofIt's missing a roof

The structures on the pink pictures worked perfectly before.

If you need any more info I'd be happy to tell you.

https://www.mediafire.com/file/qk6s7pcfgcyf2gq/AR.zip/file <---workspace btw

Attachment Size
Crash Report5.21 KB 5.21 KB
latest_1.zip11.63 KB 11.63 KB

Issue comments

If it crashes, provide crash logs please too.

If you know which snapshot first caused this problem, please let me know this too. Thanks!

I believe it started happening in Mcreator 2020.4 EAP (30407)

But the bug could have also been in Mcreator 2020.4 EAP (28114) I am not sure, Wasn't doing much with structures...

Crashlog is provided in the attachments

I managed to fix the crash, but I could not resolve some structures breaking, at least smaller work for sure. I will investigate why bigger don't spawn when I get some time for this. Added to my internal TODO.

You will have to wait until after the chunks are generated fully before you go in and place your structure.

If you add structures to the world the instant a structure is generated, they will probably be spawned outside of loaded chunks and thus Minecraft's world gen will just write over them.

The way I've circumvented this is to spawn a block in place of the structure, then run a procedure "on update tick" that places the actual structure. This will make the structure spawn 10 ticks (or whatever you choose to set the blocks tick rate to) after the initial structure is placed, leaving Minecraft plenty of time to be finished generating the chunk so you can come in and place your structure.

Hope that makes sense. I'm not the greatest at explaining.

If you add structures to the world the instant a structure is generated, they will probably be spawned outside of loaded chunks and thus Minecraft's world gen will just write over them.

That is correct. In some cases, chunks might still get loaded before the full structure loads, but not always as wordgen is now threaded.

Jigsaw will be proper solution to this once it gets added :)



Donate to MCreator

By donating to developers you can speed up development, as with more resources, we can dedicate more time to MCreator. It is a free project made by developers working on it in their free time.