Advancement name and description bugged with Data Packs.

Status

Fixed

Issue description

I was testing data pack features, and I discover a bug with custom advancements.

When we create an advancement, we can put a name and a description, but when we are in the game, the advancement name, description and new advancement tab haven't the name. They have advancement.advancementidname.title.

P-S: Is it normal we can't test data packs direclty into MCreator?

P-S 2:The new advancement system is really cool, but I suggest you to add to have the "AND" and "OR" procedure block. With this, we will be able to make an advancement when the player will have entered into each biome (or a selection of biome).

Issue comments

I can confirm this bug. Too bad you did not report this when snapshots were there, I will release a patch if other problematic bugs will get found, otherwise this one will wait for 2020.2. Turn on the update notifications if there will be a patch ;)

P-S: Is it normal we can't test data packs direclty into MCreator?

Yes, Forge bundles Minecraft in it, but data packs are not Minecraft Forge based.

P-S 2:The new advancement system is really cool, but I suggest you to add to have the "AND" and "OR" procedure block. With this, we will be able to make an advancement when the player will have entered into each biome (or a selection of biome).

I am not sure this is actually possible. JSON as "programming language" in the vanilla system is quite limited. This is why these triggers are intended for basic use cases, but procedures for more advanced use cases.

I didn’t test Data pack during the snapshot time.

And thanks for the informations.

No worries ;)

AND/OR triggers are sort of doables. Advancements have a "requirements" field, which is a list of lists of triggers. At least one trigger from each list must be completed. So it's more like "(a or b or c) and (d or e) and (f)".

You are right on this one. But the problem is that the definition of AND/OR in JSON is non-linear - not procedural like in normal programming languages, and our procedure editor is linear conversion right now.

I will and plan to improve procedural block editor to support more advanced features of the JSON files, though.

Hm, I see. Would it be doable with something similar to a "if else" block? Something like
"If at least one of"
   criteria 1
   criteria 2
"and at least one of"
   criteria 3
   criteria 4
   criteria 5

Yes, but the translation of your statements to JSON is not linear like with programming languages such as Java where your logical tree of conditions can be translated 1:1 to Java.

We have released a patch update to fix this and a few other bugs:

2020.1.05113

[Bugfix, 1.14.4] Custom dimension portals did not work

[Bugfix, 1.14.4] Data pack pack_format was set to 1 instead of 4

[Bugfix #56503] Vanilla advancement triggers did not work with custom blocks and items

[Bugfix #56505, 1.14.4] Advancement name and descriptions did not work in data packs

[Bugfix #56537, 1.14.4] Comparator item was mapped to a composter

If you have update notifications turned on in MCreator, you will be notified if you need to patch on your next launch of MCreator.

To apply patch, redownload and reinstall MCreator 2020.1