Desactivate "Enable Weather" for Custom Dimensions doesn't rebuild the workspace

Published by Goldorion on Sun, 12/01/2019 - 15:45
Upvotes: 1
Issue description

Hi,

When we create a new dimension, we can activate or desactivate the weather, but when we choose to don't activate this option, the mod doesn't want to rebuild the workspace because there is an error. The code is like this :

@Override
public void updateWeather() {
}

But, it  should be like this :

public void updateWeather() {
}

 

I hope you will fix this in the next snapshot/release, and I give you enought details (I give you my workspace if you need it).

P-S : Oh and I have the same bug that this ticket. https://mcreator.net/tracker/issue/54898

Issue comments

Thank you for the report. I can confirm this.

A proper solution is:

@Override public void updateWeather(Runnable defaultWeather) {
}

I will fix this in the next update/release.

 

For the tabs:

I can confirm this to some degree. Minecraft seems to cache this value somewhere. Deleting run folder of workspace fixes the tab order. But we can not really fix this, final users will have the proper order.



Donate to MCreator

By donating to developers you can speed up development, as with more resources, we can dedicate more time to MCreator. It is a free project made by developers working on it in their free time.