Mob doesn't despawn with the procedure "Despawn provided entity"

Started by TheSwitzVirgin on Sun, 03/29/2020 - 06:54

Topic category: Help with Minecraft modding (Java Edition)

So I want to swap a mob to another when offered gold ingot and this is the event I have until now:

But instead of despawning the mob, it despawn the Player.

Edited by TheSwitzVirgin on Sun, 03/29/2020 - 06:55

Perhaps you could use the "Entity (sub)type of" block to only check for your entity and despawn that? I'm guessing it's targeting the player because the GUI test you have at the top checks the player, so in that instance, the provided entity is the player.

Jump to top Permalink

And how do I do that? I already tried with "if current entity is (the custom mob) = true" and it doesn't despawn.

Jump to top Permalink

Well then maybe you could use a custom code snippet. Try using one in place of "despawn provided entity" and type entity.remove(); into it (with the semicolon)

Jump to top Permalink

how do you add the entity.remove(); where is the custom code snippet

Jump to top Permalink

It's located in the "Advanced" tab when making a procedure. It's purple and has a text box as its only input

Jump to top Permalink

The procedure "despawn provided entity" already add that code like ilustrated on the image:

https://imgur.com/QOAAgS2

And it despawns the player.

Jump to top Permalink

I see. Could you paste the full code? Does it mention any other entities than the one on that line?

Jump to top Permalink

Sure, this is the full code so far:

package net.mcreator.empire_war;

import net.minecraft.world.World;
import net.minecraft.util.text.StringTextComponent;
import net.minecraft.item.Items;
import net.minecraft.item.ItemStack;
import net.minecraft.inventory.IInventory;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.entity.Entity;

import java.util.HashMap;

@Elementsempire_war.ModElement.Tag
public class MCreatorHire extends Elementsempire_war.ModElement {
   public MCreatorHire(Elementsempire_war instance) {
       super(instance, 6);
   }

   public static void executeProcedure(java.util.HashMap<String, Object> dependencies) {
       if (dependencies.get("entity") == null) {
           System.err.println("Failed to load dependency entity for procedure MCreatorHire!");
           return;
       }
       if (dependencies.get("x") == null) {
           System.err.println("Failed to load dependency x for procedure MCreatorHire!");
           return;
       }
       if (dependencies.get("y") == null) {
           System.err.println("Failed to load dependency y for procedure MCreatorHire!");
           return;
       }
       if (dependencies.get("z") == null) {
           System.err.println("Failed to load dependency z for procedure MCreatorHire!");
           return;
       }
       if (dependencies.get("guiinventory") == null) {
           System.err.println("Failed to load dependency guiinventory for procedure MCreatorHire!");
           return;
       }
       if (dependencies.get("world") == null) {
           System.err.println("Failed to load dependency world for procedure MCreatorHire!");
           return;
       }
       Entity entity = (Entity) dependencies.get("entity");
       int x = (int) dependencies.get("x");
       int y = (int) dependencies.get("y");
       int z = (int) dependencies.get("z");
       HashMap guiinventory = (HashMap) dependencies.get("guiinventory");
       World world = (World) dependencies.get("world");
       if (((new Object() {
           public ItemStack getItemStack(int sltid) {
               IInventory inv = (IInventory) guiinventory.get("Trading");
               if (inv != null)
                   return inv.getStackInSlot(sltid);
               return ItemStack.EMPTY;
           }
       }.getItemStack((int) (0))).getItem() == new ItemStack(Items.GOLD_INGOT, (int) (1)).getItem())) {
           if (!world.isRemote) {
               Entity entityToSpawn = new MCreatorWarrior.CustomEntity(MCreatorWarrior.entity, world);
               entityToSpawn.setLocationAndAngles(x, y, z, world.rand.nextFloat() * 360F, 0);
               world.addEntity(entityToSpawn);
           }
           entity.remove();
       } else {
           if (entity instanceof PlayerEntity && !world.isRemote) {
               ((PlayerEntity) entity).sendStatusMessage(new StringTextComponent("Give me some Gold first and then we talk."), (true));
           }
           if (entity instanceof PlayerEntity)
               ((PlayerEntity) entity).closeScreen();
       }
   }
}

I'm not sure if it mentions another entity or not.

Jump to top Permalink

It doesn't. I think the only way to make this work is to put this code into the entity directly instead of using a procedure. I'm not sure how comfortable you are with coding, but if you can find in you custom entity where this procedure is triggered, you could basically copy-paste this code with a few tweaks. If you do that, then you'd be able to differentiate the player from the entity.

Jump to top Permalink